Skip to content

[Significant events][Streams] Zero shot copy update#260955

Open
boriskirov wants to merge 2 commits intoelastic:mainfrom
boriskirov:streams-sig-event-content-fix
Open

[Significant events][Streams] Zero shot copy update#260955
boriskirov wants to merge 2 commits intoelastic:mainfrom
boriskirov:streams-sig-event-content-fix

Conversation

@boriskirov
Copy link
Copy Markdown
Contributor

@boriskirov boriskirov commented Apr 2, 2026 •
edited
Loading

Summary

This is a proposal to update the copy on the significant events tab in Streams to communicate that this is an onboarding task.

image

@boriskirov boriskirov requested a review from ruflin April 2, 2026 15:08
@boriskirov boriskirov requested a review from a team as a code owner April 2, 2026 15:08
@boriskirov boriskirov added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) Team:SigEvents Project team working on Significant Events labels Apr 2, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 2, 2026 •
edited
Loading

Approvability

Verdict: Needs human review

Simple UI copy and button styling changes with no runtime behavior impact. However, the file is owned by @elastic/obs-sig-events-team and the author is not a designated owner, so the owning team should review.

You can customize Macroscope's approvability policy. Learn more.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 90e3ed78-1622-490b-82d6-6c412f436f80

📥 Commits

Reviewing files that changed from the base of the PR and between 14771a3 and 2d1cfd1.

📒 Files selected for processing (1)
  • x-pack/platform/plugins/shared/streams_app/public/components/sig_events/stream_detail_significant_events_view/empty_state/index.tsx
📝 Walkthrough

Walkthrough

The empty state UI in the significant events stream detail view was updated to represent an unonboarded stream state. The component's title message and description text were changed. The primary button label was updated from "Generate" to use a new localized string for "Onboard stream". Button styling was adjusted by replacing the fill property with a fixed medium size while preserving the existing loading/disabled states and generation/canceling label logic.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

Comment @coderabbitai help to get the list of available commands and usage tips.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 2, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #204 / discover/group6 discover unsaved changes notification indicator should not show the notification indicator initially nor after changes to a draft saved search
  • [job] [logs] FTR Configs #188 / Fleet Endpoints fleet policy secrets fleet server version requirements "after each" hook for "should convert plain text values to secrets once fleet server requirements are met"
  • [job] [logs] Scout: [ platform / discover ] plugin / local-stateful-classic - Traces in Discover - Overview tab content and actions - Trace Summary section - waterfall actions and Open in Discover

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 1.9MB 1.9MB +27.0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruflin ruflin Awaiting requested review from ruflin

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) release_note:skip Skip the PR/issue when compiling release notes Team:SigEvents Project team working on Significant Events

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@boriskirov @elasticmachine @kibanamachine